summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYuri Gushin <yuri@ecl-labs.org>2006-06-27 03:01:03 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2006-06-29 16:57:44 -0700
commit9abdcf6b6cf387035d934c77bf9ebe5e747166f9 (patch)
tree2ea946e64ed3b80d872376856b3873a43ebce82f
parent40a839fdbd5d76cebb2a61980bc1fc7ecd784be2 (diff)
downloadop-kernel-dev-9abdcf6b6cf387035d934c77bf9ebe5e747166f9.zip
op-kernel-dev-9abdcf6b6cf387035d934c77bf9ebe5e747166f9.tar.gz
[NETFILTER]: xt_tcpudp: fix double unregistration in error path
"xt_unregister_match(AF_INET, &tcp_matchstruct)" is called twice, leaving "udp_matchstruct" registered, in case of a failure in the registration of the udp6 structure. Signed-off-by: Yuri Gushin <yuri@ecl-labs.org> Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/netfilter/xt_tcpudp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/xt_tcpudp.c b/net/netfilter/xt_tcpudp.c
index 1b61dac..a9a63aa 100644
--- a/net/netfilter/xt_tcpudp.c
+++ b/net/netfilter/xt_tcpudp.c
@@ -260,7 +260,7 @@ static int __init xt_tcpudp_init(void)
return ret;
out_unreg_udp:
- xt_unregister_match(&tcp_matchstruct);
+ xt_unregister_match(&udp_matchstruct);
out_unreg_tcp6:
xt_unregister_match(&tcp6_matchstruct);
out_unreg_tcp:
OpenPOWER on IntegriCloud