summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXiubo Li <Li.Xiubo@freescale.com>2014-08-18 17:08:44 +0800
committerThierry Reding <thierry.reding@gmail.com>2014-08-25 14:38:12 +0200
commit533acc0e8df7d6553f11cf91c177211cb6037968 (patch)
tree812cd4e995141cfe2c1ce2533f52f4017d5af6b1
parentad16202de8d884c10ef7637ea3982953519c2418 (diff)
downloadop-kernel-dev-533acc0e8df7d6553f11cf91c177211cb6037968.zip
op-kernel-dev-533acc0e8df7d6553f11cf91c177211cb6037968.tar.gz
pwm: Fix possible ZERO_SIZE_PTR pointer dereferencing error.
Since we cannot make sure the 'chip->npwm' will always be none zero here, and then if either equal to zero, the kzalloc() will return ZERO_SIZE_PTR, which equals to ((void *)16). So this patch fix this with just doing the zero check before calling kzalloc(). Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
-rw-r--r--drivers/pwm/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index d2c3592..8c748b1 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -236,7 +236,7 @@ int pwmchip_add(struct pwm_chip *chip)
int ret;
if (!chip || !chip->dev || !chip->ops || !chip->ops->config ||
- !chip->ops->enable || !chip->ops->disable)
+ !chip->ops->enable || !chip->ops->disable || !chip->npwm)
return -EINVAL;
mutex_lock(&pwm_lock);
OpenPOWER on IntegriCloud