summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWolfram Sang <w.sang@pengutronix.de>2010-03-20 15:13:02 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2010-04-30 09:30:09 -0700
commitee58cb2bcda99ae934176ad5ae66f7699d23cd3d (patch)
treea75183e45e26437b644b196d515c6f1a0999442c
parentb36fc07dc3c742bd704c59d85c8cf12585a00e41 (diff)
downloadop-kernel-dev-ee58cb2bcda99ae934176ad5ae66f7699d23cd3d.zip
op-kernel-dev-ee58cb2bcda99ae934176ad5ae66f7699d23cd3d.tar.gz
Staging: iio: adc: fix dangling pointers
Fix I2C-drivers which missed setting clientdata to NULL before freeing the structure it points to. Also fix drivers which do this _after_ the structure was freed already. Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/iio/adc/max1363_core.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c
index 790d1cc..773f1d1 100644
--- a/drivers/staging/iio/adc/max1363_core.c
+++ b/drivers/staging/iio/adc/max1363_core.c
@@ -557,6 +557,7 @@ error_put_reg:
if (!IS_ERR(st->reg))
regulator_put(st->reg);
error_free_st:
+ i2c_set_clientdata(client, NULL);
kfree(st);
error_ret:
@@ -574,6 +575,7 @@ static int max1363_remove(struct i2c_client *client)
regulator_disable(st->reg);
regulator_put(st->reg);
}
+ i2c_set_clientdata(client, NULL);
kfree(st);
return 0;
OpenPOWER on IntegriCloud