diff options
| author | Andrzej Hajda <a.hajda@samsung.com> | 2015-09-21 15:33:55 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-09-22 16:14:32 -0700 |
| commit | 7e724da64491b20257d46f100bcc6d6214c37b70 (patch) | |
| tree | af5bbabf0a8e64f89247aeaee99803d09afe196a | |
| parent | e79dd09b605f42d85d1a5605ad0fe96b970695e9 (diff) | |
| download | op-kernel-dev-7e724da64491b20257d46f100bcc6d6214c37b70.zip op-kernel-dev-7e724da64491b20257d46f100bcc6d6214c37b70.tar.gz | |
rndis_wlan: fix checking for default value
Thresholds uses -1 to indicate that default value should be used.
Since thresholds are unsigned sign checking makes no sense.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/wireless/rndis_wlan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c index 71a825c..a13d1f2 100644 --- a/drivers/net/wireless/rndis_wlan.c +++ b/drivers/net/wireless/rndis_wlan.c @@ -1236,7 +1236,7 @@ static int set_rts_threshold(struct usbnet *usbdev, u32 rts_threshold) netdev_dbg(usbdev->net, "%s(): %i\n", __func__, rts_threshold); - if (rts_threshold < 0 || rts_threshold > 2347) + if (rts_threshold == -1 || rts_threshold > 2347) rts_threshold = 2347; tmp = cpu_to_le32(rts_threshold); |
