summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHugh Dickins <hugh@veritas.com>2006-03-09 17:33:34 -0800
committerLinus Torvalds <torvalds@g5.osdl.org>2006-03-09 19:47:36 -0800
commit85a6cd03a97f04ffff7bfedfa3172894ca9a617b (patch)
tree6dfcb724b0ed7b2cb9b33c0c18933f0d915bc966
parent6218cf4410cfce7bc7e89834e73525b124625d4c (diff)
downloadop-kernel-dev-85a6cd03a97f04ffff7bfedfa3172894ca9a617b.zip
op-kernel-dev-85a6cd03a97f04ffff7bfedfa3172894ca9a617b.tar.gz
[PATCH] page_add_file_rmap(): remove BUG_ON()s
Remove two early-development BUG_ONs from page_add_file_rmap. The pfn_valid test (originally useful for checking that nobody passed an artificial struct page) comes too late, since we already have the struct page. The PageAnon test (useful when anon was first distinguished from file rmap) prevents ->nopage implementations from reusing ->mapping, which would otherwise be available. Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--mm/rmap.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/mm/rmap.c b/mm/rmap.c
index d8ce5ff..67f0e20 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -537,9 +537,6 @@ void page_add_new_anon_rmap(struct page *page,
*/
void page_add_file_rmap(struct page *page)
{
- BUG_ON(PageAnon(page));
- BUG_ON(!pfn_valid(page_to_pfn(page)));
-
if (atomic_inc_and_test(&page->_mapcount))
__inc_page_state(nr_mapped);
}
OpenPOWER on IntegriCloud