diff options
| author | Andy Grover <andy.grover@oracle.com> | 2009-04-09 14:09:40 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-04-09 17:21:18 -0700 |
| commit | 7acd4a794c1530af063e51f3f7171e75556458f3 (patch) | |
| tree | 4c213f984afa23fbb704a9e94f6f754ed50bdb5d | |
| parent | 7b70d0336da777c00395cc7a503497c2cdabd1a8 (diff) | |
| download | op-kernel-dev-7acd4a794c1530af063e51f3f7171e75556458f3.zip op-kernel-dev-7acd4a794c1530af063e51f3f7171e75556458f3.tar.gz | |
RDS: Fix ordering in a conditional
Putting the constant first is a supposed "best practice" that actually makes
the code harder to read.
Thanks to Roland Dreier for finding a bug in this "simple, obviously correct"
patch.
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/rds/rdma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rds/rdma.c b/net/rds/rdma.c index eaeeb91..e390dc7 100644 --- a/net/rds/rdma.c +++ b/net/rds/rdma.c @@ -155,7 +155,7 @@ static int rds_pin_pages(unsigned long user_addr, unsigned int nr_pages, nr_pages, write, 0, pages, NULL); up_read(¤t->mm->mmap_sem); - if (0 <= ret && (unsigned) ret < nr_pages) { + if (ret >= 0 && ret < nr_pages) { while (ret--) put_page(pages[ret]); ret = -EFAULT; |
