summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2011-11-10 09:44:46 +0100
committerJohn W. Linville <linville@tuxdriver.com>2011-11-11 12:32:51 -0500
commitd64d373ffed925f29c3e68a8d6f45677a622054e (patch)
tree8fb0699d7e249e2862f11d85dc858d22e2a13999
parente0830f71e7b8c2c58031c9692384819943162e9b (diff)
downloadop-kernel-dev-d64d373ffed925f29c3e68a8d6f45677a622054e.zip
op-kernel-dev-d64d373ffed925f29c3e68a8d6f45677a622054e.tar.gz
nl80211: fix compiler warning
John reported the following warning: net/wireless/nl80211.c: In function ‘nl80211_tx_mgmt’: net/wireless/nl80211.c:5286:8: warning: ‘hdr’ may be used uninitialized in this function Evidently, his version of gcc isn't able to see that when "msg" is initialized, "hdr" must also be. My gcc, 4.6.1, can actually see that and doesn't warn. Simply initialize the variable to NULL. That means if the compiler was ever right we'll crash though so isn't really optimal since it may hide warnings from the compiler when somebody modifies this code in the future. Reported-by: John Linville <linville@tuxdriver.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--net/wireless/nl80211.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 864fcb6..258fb88 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -5283,7 +5283,7 @@ static int nl80211_tx_mgmt(struct sk_buff *skb, struct genl_info *info)
bool channel_type_valid = false;
u32 freq;
int err;
- void *hdr;
+ void *hdr = NULL;
u64 cookie;
struct sk_buff *msg = NULL;
unsigned int wait = 0;
OpenPOWER on IntegriCloud