summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Hüwe <PeterHuewe@gmx.de>2012-04-14 13:42:59 +0000
committerDavid S. Miller <davem@davemloft.net>2012-04-15 03:23:31 -0400
commit8831a3f2c9ee7d952e6d7a018d11c0c9c5b56749 (patch)
tree8e3f7c54f9fc5aa95be9be0fdd95ade6bff8ca85
parentcf22f9a2b83e72082c43ef5c942d5daf9301da8e (diff)
downloadop-kernel-dev-8831a3f2c9ee7d952e6d7a018d11c0c9c5b56749.zip
op-kernel-dev-8831a3f2c9ee7d952e6d7a018d11c0c9c5b56749.tar.gz
isdn/hysdn: Convert to kstrtoul_from_user
This patch replaces the code for getting an number from a userspace buffer by a simple call to kstroul_from_user. This makes it easier to read and less error prone. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/isdn/hysdn/hysdn_proclog.c10
1 files changed, 1 insertions, 9 deletions
diff --git a/drivers/isdn/hysdn/hysdn_proclog.c b/drivers/isdn/hysdn/hysdn_proclog.c
index ba91333..88e4f0e 100644
--- a/drivers/isdn/hysdn/hysdn_proclog.c
+++ b/drivers/isdn/hysdn/hysdn_proclog.c
@@ -156,17 +156,9 @@ static ssize_t
hysdn_log_write(struct file *file, const char __user *buf, size_t count, loff_t *off)
{
int rc;
- unsigned char valbuf[128];
hysdn_card *card = file->private_data;
- if (count > (sizeof(valbuf) - 1))
- count = sizeof(valbuf) - 1; /* limit length */
- if (copy_from_user(valbuf, buf, count))
- return (-EFAULT); /* copy failed */
-
- valbuf[count] = 0; /* terminating 0 */
-
- rc = kstrtoul(valbuf, 0, &card->debug_flags);
+ rc = kstrtoul_from_user(buf, count, 0, &card->debug_flags);
if (rc < 0)
return rc;
hysdn_addlog(card, "debug set to 0x%lx", card->debug_flags);
OpenPOWER on IntegriCloud