summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJonathan Cameron <jic23@kernel.org>2014-01-03 22:02:00 +0000
committerJonathan Cameron <jic23@kernel.org>2014-03-02 21:45:28 +0000
commitdb8fa7311d1ce642134c53e175ca0ae35e021344 (patch)
tree353fe58930f0fa92f65dbdc0f8855697680965a7
parentbdc8cda1d010887c06bd8c29564b74cd61ec0a7b (diff)
downloadop-kernel-dev-db8fa7311d1ce642134c53e175ca0ae35e021344.zip
op-kernel-dev-db8fa7311d1ce642134c53e175ca0ae35e021344.tar.gz
iio:adc:vf610 ensure correct handing of interruption of wait for completion
Issue highlighted by smatch warning: CHECK drivers/iio/adc/vf610_adc.c drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never less than zero. As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if interrupted, ret must be signed. Signed-off-by: Jonathan Cameron <jic23@kernel.org> Acked-by: Fugang Duan <B38611@freescale.com>
-rw-r--r--drivers/iio/adc/vf610_adc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index 37f542e..44799eb5 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -447,7 +447,7 @@ static int vf610_read_raw(struct iio_dev *indio_dev,
{
struct vf610_adc *info = iio_priv(indio_dev);
unsigned int hc_cfg;
- unsigned long ret;
+ long ret;
switch (mask) {
case IIO_CHAN_INFO_RAW:
OpenPOWER on IntegriCloud