diff options
| author | Yossi Etigin <yosefe@Voltaire.COM> | 2008-11-12 10:24:36 -0800 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2008-11-12 10:24:36 -0800 |
| commit | fe25c56190bbc0951d7c53b4ccd148e669d69938 (patch) | |
| tree | 014505ce749ad84073d76f4c12e8212c1be59076 | |
| parent | 332edc2f7fa58b818dfed1cede60272eecc27c0a (diff) | |
| download | op-kernel-dev-fe25c56190bbc0951d7c53b4ccd148e669d69938.zip op-kernel-dev-fe25c56190bbc0951d7c53b4ccd148e669d69938.tar.gz | |
IPoIB: Don't enable NAPI when it's already enabled
If a P_Key is not present when an interface is created, ipoib_open()
will return after doing napi_enable(). ipoib_open() will be called
again from ipoib_pkey_poll() when the P_Key appears, after NAPI has
already been enabled, and try to enable it again. This triggers a
BUG_ON() in napi_enable().
Fix this by moving the call to napi_enable() to after the test for
P_Key presence.
Signed-off-by: Yossi Etigin <yosefe@voltaire.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
| -rw-r--r-- | drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index fddded7..b1eeb5a 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -106,12 +106,13 @@ int ipoib_open(struct net_device *dev) ipoib_dbg(priv, "bringing up interface\n"); - napi_enable(&priv->napi); set_bit(IPOIB_FLAG_ADMIN_UP, &priv->flags); if (ipoib_pkey_dev_delay_open(dev)) return 0; + napi_enable(&priv->napi); + if (ipoib_ib_dev_open(dev)) { napi_disable(&priv->napi); return -EINVAL; |
