summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMing Lei <tom.leiming@gmail.com>2012-11-03 17:48:16 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-11-14 15:07:18 -0800
commit6a927857d890658789e6e54b058ef8527de8200a (patch)
tree96caa4c27cf460927601fae8490dffaeb6a421f4
parent27602842060484b564cd725241b402b0bddfb830 (diff)
downloadop-kernel-dev-6a927857d890658789e6e54b058ef8527de8200a.zip
op-kernel-dev-6a927857d890658789e6e54b058ef8527de8200a.tar.gz
firmware loader: document firmware cache mechanism
This patch documents the firmware cache mechanism so that users of request_firmware() know that it can be called safely inside device's suspend and resume callback, and the device's firmware needn't be cached any more by individual driver itself to deal with firmware loss during system resume. Signed-off-by: Ming Lei <ming.lei@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--Documentation/firmware_class/README7
-rw-r--r--drivers/base/firmware_class.c3
2 files changed, 10 insertions, 0 deletions
diff --git a/Documentation/firmware_class/README b/Documentation/firmware_class/README
index e9fce78..43fada9 100644
--- a/Documentation/firmware_class/README
+++ b/Documentation/firmware_class/README
@@ -119,3 +119,10 @@
on the setup, so I think that the choice on what firmware to make
persistent should be left to userspace.
+ about firmware cache:
+ --------------------
+ After firmware cache mechanism is introduced during system sleep,
+ request_firmware can be called safely inside device's suspend and
+ resume callback, and callers need't cache the firmware by
+ themselves any more for dealing with firmware loss during system
+ resume.
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 7888af7..d814603 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -988,6 +988,9 @@ err_put_dev:
* firmware image for this or any other device.
*
* Caller must hold the reference count of @device.
+ *
+ * The function can be called safely inside device's suspend and
+ * resume callback.
**/
int
request_firmware(const struct firmware **firmware_p, const char *name,
OpenPOWER on IntegriCloud