summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChao Yu <chao2.yu@samsung.com>2014-03-18 09:07:59 +0800
committerJaegeuk Kim <jaegeuk.kim@samsung.com>2014-03-18 10:13:02 +0900
commit04c0938844695ab97b79a477a9f57748fe97d2f5 (patch)
tree7cd1fb81cbbcc0d82984cb393634b1f404dfe6e6
parente4fc5fbfc9e285356be7e5208bb1a2fa377b2656 (diff)
downloadop-kernel-dev-04c0938844695ab97b79a477a9f57748fe97d2f5.zip
op-kernel-dev-04c0938844695ab97b79a477a9f57748fe97d2f5.tar.gz
f2fs: fix incorrect parsing with option string
Previously 'background_gc={on***,off***}' is being parsed as correct option, with this patch we cloud fix the trivial bug in mount process. Change log from v1: o need to check length of parameter suggested by Jaegeuk Kim. Signed-off-by: Chao Yu <chao2.yu@samsung.com> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
-rw-r--r--fs/f2fs/super.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 057a3ef..dbe402b 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -258,9 +258,9 @@ static int parse_options(struct super_block *sb, char *options)
if (!name)
return -ENOMEM;
- if (!strncmp(name, "on", 2))
+ if (strlen(name) == 2 && !strncmp(name, "on", 2))
set_opt(sbi, BG_GC);
- else if (!strncmp(name, "off", 3))
+ else if (strlen(name) == 3 && !strncmp(name, "off", 3))
clear_opt(sbi, BG_GC);
else {
kfree(name);
OpenPOWER on IntegriCloud