diff options
| author | Marcel Holtmann <marcel@holtmann.org> | 2014-04-16 20:04:38 -0700 |
|---|---|---|
| committer | Gustavo Padovan <gustavo.padovan@collabora.co.uk> | 2014-04-24 11:55:25 -0300 |
| commit | db5966816cd83b8daa1aee38cb1374794f1d8b8e (patch) | |
| tree | e7f7ac208228581d32a75de7e4a8e2eb030bf91a | |
| parent | b16c6604885841e1b7d2eb09a3256bf6d3d4bc8a (diff) | |
| download | op-kernel-dev-db5966816cd83b8daa1aee38cb1374794f1d8b8e.zip op-kernel-dev-db5966816cd83b8daa1aee38cb1374794f1d8b8e.tar.gz | |
Bluetooth: Return EOPNOTSUPP for HCISETRAW ioctl command
The HCISETRAW ioctl command is not really useful. To utilize raw and
direct access to the HCI controller, the HCI User Channel feature has
been introduced. Return EOPNOTSUPP to indicate missing support for
this command.
For legacy reasons hcidump used to use HCISETRAW for permission check
to return proper error codes to users. To keep backwards compability
return EPERM in case the caller does not have CAP_NET_ADMIN capability.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
| -rw-r--r-- | net/bluetooth/hci_sock.c | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c index b9a418e..f608bff 100644 --- a/net/bluetooth/hci_sock.c +++ b/net/bluetooth/hci_sock.c @@ -524,16 +524,7 @@ static int hci_sock_bound_ioctl(struct sock *sk, unsigned int cmd, case HCISETRAW: if (!capable(CAP_NET_ADMIN)) return -EPERM; - - if (test_bit(HCI_QUIRK_RAW_DEVICE, &hdev->quirks)) - return -EPERM; - - if (arg) - set_bit(HCI_RAW, &hdev->flags); - else - clear_bit(HCI_RAW, &hdev->flags); - - return 0; + return -EOPNOTSUPP; case HCIGETCONNINFO: return hci_get_conn_info(hdev, (void __user *) arg); |
