diff options
| author | Benjamin Li <benjamin.li@qlogic.com> | 2007-02-26 11:06:32 -0800 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2007-02-27 04:21:43 -0500 |
| commit | d2d76b8db4e681944801870f81b859c5bf9964cf (patch) | |
| tree | acddd021773905cbd595c52d1c6934e007135921 | |
| parent | 546faf077e14930df2ebddad9190db42f1c42f0f (diff) | |
| download | op-kernel-dev-d2d76b8db4e681944801870f81b859c5bf9964cf.zip op-kernel-dev-d2d76b8db4e681944801870f81b859c5bf9964cf.tar.gz | |
qla3xxx: Remove unnecessary memset() in qla3xxx_send()
We do not need to zero out the 64 byte MAC request I/O control block.
By zeroing out the control block and setting it to proper fields is
redundant work. This is because in the qla3xxx_send() function we will
already set the proper fields in this structure. The unused fields are
not looked at by the hardware and do not need to be zeroed out.
Signed-off-by: Benjamin Li <benjamin.li@qlogic.com>
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| -rwxr-xr-x | drivers/net/qla3xxx.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index 91d91ca..9fbb871 100755 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -2188,7 +2188,6 @@ static int ql3xxx_send(struct sk_buff *skb, struct net_device *ndev) } mac_iocb_ptr = tx_cb->queue_entry; - memset((void *)mac_iocb_ptr, 0, sizeof(struct ob_mac_iocb_req)); mac_iocb_ptr->opcode = qdev->mac_ob_opcode; mac_iocb_ptr->flags |= qdev->mb_bit_mask; mac_iocb_ptr->transaction_id = qdev->req_producer_index; |
