diff options
| author | Petr Matousek <pmatouse@redhat.com> | 2015-03-11 12:16:09 +0100 |
|---|---|---|
| committer | Marcelo Tosatti <mtosatti@redhat.com> | 2015-03-12 22:02:46 -0300 |
| commit | c1a6bff28cbff796bf6e7db5cf42ec9244911be2 (patch) | |
| tree | 09dd8804b784217ec2fd387bbe2ecf230c6b837e | |
| parent | dc9be0fac70a2ad86e31a81372bb0bdfb6945353 (diff) | |
| download | op-kernel-dev-c1a6bff28cbff796bf6e7db5cf42ec9244911be2.zip op-kernel-dev-c1a6bff28cbff796bf6e7db5cf42ec9244911be2.tar.gz | |
kvm: x86: i8259: return initialized data on invalid-size read
If data is read from PIC with invalid access size, the return data stays
uninitialized even though success is returned.
Fix this by always initializing the data.
Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Nadav Amit <nadav.amit@gmail.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
| -rw-r--r-- | arch/x86/kvm/i8259.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c index cc31f7c..9541ba3 100644 --- a/arch/x86/kvm/i8259.c +++ b/arch/x86/kvm/i8259.c @@ -507,6 +507,7 @@ static int picdev_read(struct kvm_pic *s, return -EOPNOTSUPP; if (len != 1) { + memset(val, 0, len); pr_pic_unimpl("non byte read\n"); return 0; } |
