summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven Rostedt <srostedt@redhat.com>2010-11-08 16:35:48 -0500
committerSteven Rostedt <rostedt@goodmis.org>2010-11-18 11:23:10 -0500
commit9386c6ab7a33044d9907b00fc80976292bb02c2d (patch)
tree8648611eb32002e523d7ffa73ee8e103e5f5880f
parentdc89568884ae1b8b96ca6fffe83b404ae472750e (diff)
downloadop-kernel-dev-9386c6ab7a33044d9907b00fc80976292bb02c2d.zip
op-kernel-dev-9386c6ab7a33044d9907b00fc80976292bb02c2d.tar.gz
ktest: Use oldnoconfig instead of yes command
Running the command "yes ''" through the make oldconfig may enable things we do not want enabled. If something is default enabled, the yes command with '' as an argument will enable it. Use oldnoconfig, which runs everything as if 'no' was used. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r--tools/testing/ktest/ktest.pl5
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index a7e86e3..5bd0075 100644
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -694,7 +694,6 @@ sub check_buildlog {
sub build {
my ($type) = @_;
my $defconfig = "";
- my $append = "";
unlink $buildlog;
@@ -707,7 +706,7 @@ sub build {
# old config can ask questions
if ($type eq "oldconfig") {
- $append = "yes ''|";
+ $type = "oldnoconfig";
# allow for empty configs
run_command "touch $outputdir/.config";
@@ -737,7 +736,7 @@ sub build {
$defconfig = "KCONFIG_ALLCONFIG=$minconfig";
}
- run_command "$append $defconfig $make $type" or
+ run_command "$defconfig $make $type" or
dodie "failed make config";
$redirect = "$buildlog";
OpenPOWER on IntegriCloud