summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Beulich <jbeulich@novell.com>2009-05-06 13:02:19 +0100
committerH. Peter Anvin <hpa@zytor.com>2009-05-07 21:42:39 -0700
commit61438766514a2d7f191ce1b3cf6812eabbef4ef7 (patch)
tree4ce81e8bbdc731812e54ed4def92eac4f266cbd6
parente0e5ea3268db428d19e1c5fa00e6f583861cbdbd (diff)
downloadop-kernel-dev-61438766514a2d7f191ce1b3cf6812eabbef4ef7.zip
op-kernel-dev-61438766514a2d7f191ce1b3cf6812eabbef4ef7.tar.gz
x86: fix boot hang in early_reserve_e820()
If the first non-reserved (sub-)range doesn't fit the size requested, an endless loop will be entered. If a range returned from find_e820_area_size() turns out insufficient in size, the range must be skipped before calling the function again. [ Impact: fixes boot hang on some platforms ] Signed-off-by: Jan Beulich <jbeulich@novell.com> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
-rw-r--r--arch/x86/kernel/e820.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index ef2c356..0062813 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -1074,12 +1074,13 @@ u64 __init early_reserve_e820(u64 startt, u64 sizet, u64 align)
u64 addr;
u64 start;
- start = startt;
- while (size < sizet && (start + 1))
+ for (start = startt; ; start += size) {
start = find_e820_area_size(start, &size, align);
-
- if (size < sizet)
- return 0;
+ if (!(start + 1))
+ return 0;
+ if (size >= sizet)
+ break;
+ }
#ifdef CONFIG_X86_32
if (start >= MAXMEM)
OpenPOWER on IntegriCloud