diff options
| author | Patrick McHardy <kaber@trash.net> | 2014-01-09 18:42:41 +0000 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-01-09 20:17:16 +0100 |
| commit | 44a6f0df039ee7ddeebc88327dd61f0afb53baa7 (patch) | |
| tree | 85d4b88176be4fad900c0535fc45a9b87ef07667 | |
| parent | 7047f9d052c379e14b7693bb9f1b766827d0bc40 (diff) | |
| download | op-kernel-dev-44a6f0df039ee7ddeebc88327dd61f0afb53baa7.zip op-kernel-dev-44a6f0df039ee7ddeebc88327dd61f0afb53baa7.tar.gz | |
netfilter: nf_tables: prohibit deletion of a table with existing sets
We currently leak the set memory when deleting a table that still has
sets in it. Return EBUSY when attempting to delete a table with sets.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| -rw-r--r-- | net/netfilter/nf_tables_api.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index c352614..36add31 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -467,7 +467,7 @@ static int nf_tables_deltable(struct sock *nlsk, struct sk_buff *skb, if (IS_ERR(table)) return PTR_ERR(table); - if (table->use) + if (!list_empty(&table->chains) || !list_empty(&table->sets)) return -EBUSY; list_del(&table->list); |
