summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorApollon Oikonomopoulos <apollon@noc.grnet.gr>2010-12-07 09:43:30 +0000
committerDavid S. Miller <davem@davemloft.net>2010-12-08 12:13:44 -0800
commit171995e5d82dcc92bea37a7d2a2ecc21068a0f19 (patch)
treed0c6d6650a244f4860edff9f9d20ae9ea98dd85f
parent408cc293c29ada769ae772420a39961320da1854 (diff)
downloadop-kernel-dev-171995e5d82dcc92bea37a7d2a2ecc21068a0f19.zip
op-kernel-dev-171995e5d82dcc92bea37a7d2a2ecc21068a0f19.tar.gz
x25: decrement netdev reference counts on unload
x25 does not decrement the network device reference counts on module unload. Thus unregistering any pre-existing interface after unloading the x25 module hangs and results in unregister_netdevice: waiting for tap0 to become free. Usage count = 1 This patch decrements the reference counts of all interfaces in x25_link_free, the way it is already done in x25_link_device_down for NETDEV_DOWN events. Signed-off-by: Apollon Oikonomopoulos <apollon@noc.grnet.gr> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/x25/x25_link.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c
index 73e7b95..b25c646 100644
--- a/net/x25/x25_link.c
+++ b/net/x25/x25_link.c
@@ -394,6 +394,7 @@ void __exit x25_link_free(void)
list_for_each_safe(entry, tmp, &x25_neigh_list) {
nb = list_entry(entry, struct x25_neigh, node);
__x25_remove_neigh(nb);
+ dev_put(nb->dev);
}
write_unlock_bh(&x25_neigh_list_lock);
}
OpenPOWER on IntegriCloud