diff options
| author | Xi Wang <xi.wang@gmail.com> | 2011-12-12 21:55:52 +0000 |
|---|---|---|
| committer | Ben Myers <bpm@sgi.com> | 2011-12-16 15:17:42 -0600 |
| commit | 093019cf1b18dd31b2c3b77acce4e000e2cbc9ce (patch) | |
| tree | d181c46d1738fc53a48202c1a46ef4221847e486 | |
| parent | 687d1c5e8e26f68b0defb1b9ccd85a0955325b9d (diff) | |
| download | op-kernel-dev-093019cf1b18dd31b2c3b77acce4e000e2cbc9ce.zip op-kernel-dev-093019cf1b18dd31b2c3b77acce4e000e2cbc9ce.tar.gz | |
xfs: fix acl count validation in xfs_acl_from_disk()
Commit fa8b18ed didn't prevent the integer overflow and possible
memory corruption. "count" can go negative and bypass the check.
Signed-off-by: Xi Wang <xi.wang@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
| -rw-r--r-- | fs/xfs/xfs_acl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c index 76e4266..ac702a6 100644 --- a/fs/xfs/xfs_acl.c +++ b/fs/xfs/xfs_acl.c @@ -39,7 +39,7 @@ xfs_acl_from_disk(struct xfs_acl *aclp) struct posix_acl_entry *acl_e; struct posix_acl *acl; struct xfs_acl_entry *ace; - int count, i; + unsigned int count, i; count = be32_to_cpu(aclp->acl_cnt); if (count > XFS_ACL_MAX_ENTRIES) |
