summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2012-02-20 23:22:02 +0000
committerBen Hutchings <bhutchings@solarflare.com>2012-02-22 20:48:07 +0000
commitc3cb2a874122889c036934294dbbb8ad82f53060 (patch)
treee3f1c5b9f925f3cdb42d2e94b40fb8136eb2d201
parent0b0a635f79f91f3755b6518627ea06dd0dbfd523 (diff)
downloadop-kernel-dev-c3cb2a874122889c036934294dbbb8ad82f53060.zip
op-kernel-dev-c3cb2a874122889c036934294dbbb8ad82f53060.tar.gz
sfc: Specify that the VFDI status page has page alignment and size
This requirement was meant to be implied in the name 'status page'. One out-of-tree VF driver allocates a buffer using the structure size and not a full page - hence the current odd specification - but in practice that allocation will be padded and aligned to at least 4KB. Therefore, we can specify this and have the option to extend the structure up to 4KB without worrying about VF drivers using odd-shaped buffers. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
-rw-r--r--drivers/net/ethernet/sfc/vfdi.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/vfdi.h b/drivers/net/ethernet/sfc/vfdi.h
index 656fa70..225557c 100644
--- a/drivers/net/ethernet/sfc/vfdi.h
+++ b/drivers/net/ethernet/sfc/vfdi.h
@@ -152,7 +152,8 @@ enum vfdi_op {
* all traffic at this receive queue.
* @u.mac_filter.flags: MAC filter flags.
* @u.set_status_page.dma_addr: Base address for the &struct vfdi_status.
- * This address must be such that the structure fits within a page.
+ * This address must be page-aligned and the PF may write up to a
+ * whole page (allowing for extension of the structure).
* @u.set_status_page.peer_page_count: Number of additional pages the VF
* has provided into which peer addresses may be DMAd.
* @u.set_status_page.peer_page_addr: Array of DMA addresses of pages.
OpenPOWER on IntegriCloud