summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2008-05-09 17:59:51 +0200
committerSteven Whitehouse <swhiteho@redhat.com>2008-05-12 08:57:11 +0100
commit00377d8e3842776d1da633ad9c79a16ecb548b92 (patch)
tree647be450fa7c93a5dc1ad7fa650cde9db812b833
parentad99f77778e83358c371dab7a50bde69270ed6b8 (diff)
downloadop-kernel-dev-00377d8e3842776d1da633ad9c79a16ecb548b92.zip
op-kernel-dev-00377d8e3842776d1da633ad9c79a16ecb548b92.tar.gz
[GFS2] Prefer strlcpy() over snprintf()
strlcpy is faster than snprintf when you don't use the returned value. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
-rw-r--r--fs/gfs2/ops_fstype.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index ef9c6c4..b2028c8 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -142,8 +142,8 @@ static int init_names(struct gfs2_sbd *sdp, int silent)
if (!table[0])
table = sdp->sd_vfs->s_id;
- snprintf(sdp->sd_proto_name, GFS2_FSNAME_LEN, "%s", proto);
- snprintf(sdp->sd_table_name, GFS2_FSNAME_LEN, "%s", table);
+ strlcpy(sdp->sd_proto_name, proto, GFS2_FSNAME_LEN);
+ strlcpy(sdp->sd_table_name, table, GFS2_FSNAME_LEN);
table = sdp->sd_table_name;
while ((table = strchr(table, '/')))
OpenPOWER on IntegriCloud