summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJonathan Corbet <corbet@lwn.net>2008-05-16 13:54:46 -0600
committerJonathan Corbet <corbet@lwn.net>2008-06-20 14:05:51 -0600
commitc0bed680f0ca603864375ed5f9fed4296a53aa62 (patch)
treed6421cd2f369309f0f9693083f3d3540e160e196
parentb8c71d7ae2a7f723d171d9175212b6d0a727655d (diff)
downloadop-kernel-dev-c0bed680f0ca603864375ed5f9fed4296a53aa62.zip
op-kernel-dev-c0bed680f0ca603864375ed5f9fed4296a53aa62.tar.gz
raw: BKL pushdown
Put explicit lock_kernel() calls into raw_open(), even though the existing locking looks adequate. Signed-off-by: Jonathan Corbet <corbet@lwn.net>
-rw-r--r--drivers/char/raw.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/char/raw.c b/drivers/char/raw.c
index bbfa0e2..505fcbe 100644
--- a/drivers/char/raw.c
+++ b/drivers/char/raw.c
@@ -19,6 +19,7 @@
#include <linux/cdev.h>
#include <linux/device.h>
#include <linux/mutex.h>
+#include <linux/smp_lock.h>
#include <asm/uaccess.h>
@@ -53,6 +54,7 @@ static int raw_open(struct inode *inode, struct file *filp)
return 0;
}
+ lock_kernel();
mutex_lock(&raw_mutex);
/*
@@ -79,6 +81,7 @@ static int raw_open(struct inode *inode, struct file *filp)
bdev->bd_inode->i_mapping;
filp->private_data = bdev;
mutex_unlock(&raw_mutex);
+ unlock_kernel();
return 0;
out2:
OpenPOWER on IntegriCloud