diff options
| author | Stephen Boyd <sboyd@codeaurora.org> | 2013-04-10 18:00:11 -0700 |
|---|---|---|
| committer | David Brown <davidb@codeaurora.org> | 2013-04-11 09:40:35 -0700 |
| commit | 73a8c28f167c9e7bc42eafc0bcbd298031709430 (patch) | |
| tree | 5b6a152c302c531d57a54cdb66405865c529b0ca | |
| parent | 4080d2d11a2d572228c2b8d02406e997b87ba6a5 (diff) | |
| download | op-kernel-dev-73a8c28f167c9e7bc42eafc0bcbd298031709430.zip op-kernel-dev-73a8c28f167c9e7bc42eafc0bcbd298031709430.tar.gz | |
ARM: msm: Fix uncompess.h tx underrun check
Bit 3 of the SR register is set if there is a tx underrun. If
this bit isn't set, we should loop on the tx ready bit until we
can transmit again. Otherwise we should skip the loop and
transmit immediately. The code is doing the opposite though,
checking for an underrun and then looping on the tx ready bit
causing us to never loop on the tx read bit when the tx buffer
may not be ready.
This doesn't seem to affect my 8960 device too often, but in some
cases I see a lost character or two from the decompressor prints.
This also matches what we do in the assembly in debug-macro.S.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: David Brown <davidb@codeaurora.org>
| -rw-r--r-- | arch/arm/mach-msm/include/mach/uncompress.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/mach-msm/include/mach/uncompress.h b/arch/arm/mach-msm/include/mach/uncompress.h index fa97a10..9432487 100644 --- a/arch/arm/mach-msm/include/mach/uncompress.h +++ b/arch/arm/mach-msm/include/mach/uncompress.h @@ -37,7 +37,7 @@ static void putc(int c) * Wait for TX_READY to be set; but skip it if we have a * TX underrun. */ - if (UART_DM_SR & 0x08) + if (!(UART_DM_SR & 0x08)) while (!(UART_DM_ISR & 0x80)) cpu_relax(); |
