diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-05-19 12:29:37 +0200 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2007-07-10 00:07:36 +0200 |
commit | 6552731a058a4facefd921b0b45a9a5392baa5ea (patch) | |
tree | 5b345e4f7e96e661471edf13cce37232e4b4c0ad | |
parent | 17a624869ea470e33c708871978223c3d9a4c417 (diff) | |
download | op-kernel-dev-6552731a058a4facefd921b0b45a9a5392baa5ea.zip op-kernel-dev-6552731a058a4facefd921b0b45a9a5392baa5ea.tar.gz |
ieee1394: add comments in struct hpsb_packet
to clarify who is supposed to set what
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
-rw-r--r-- | drivers/ieee1394/ieee1394_core.h | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/ieee1394/ieee1394_core.h b/drivers/ieee1394/ieee1394_core.h index ad52652..11fd324 100644 --- a/drivers/ieee1394/ieee1394_core.h +++ b/drivers/ieee1394/ieee1394_core.h @@ -37,7 +37,7 @@ struct hpsb_packet { hpsb_unused, hpsb_queued, hpsb_pending, hpsb_complete } __attribute__((packed)) state; - /* These are core internal. */ + /* These are core-internal. */ signed char tlabel; signed char ack_code; unsigned char tcode; @@ -62,11 +62,15 @@ struct hpsb_packet { /* Store jiffies for implementing bus timeouts. */ unsigned long sendtime; - /* Sizes are in bytes. *data can be DMA-mapped. */ + /* Core-internal. */ size_t allocated_data_size; /* as allocated */ + + /* Sizes are in bytes. To be set by caller of hpsb_alloc_packet. */ size_t data_size; /* as filled in */ size_t header_size; /* as filled in, not counting the CRC */ - quadlet_t *data; + + /* Buffers */ + quadlet_t *data; /* can be DMA-mapped */ quadlet_t header[5]; quadlet_t embedded_data[0]; /* keep as last member */ }; |