summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWANG Cong <xiyou.wangcong@gmail.com>2015-04-15 11:48:49 -0700
committerDavid S. Miller <davem@davemloft.net>2015-04-16 12:11:19 -0400
commit540207ae69777b85d167df28f469e77f0fcbb8f9 (patch)
tree1b69372a41f65d3359da8c81f9ad390020b5b636
parentc3de6317d748e23b9e46ba36e10483728d00d144 (diff)
downloadop-kernel-dev-540207ae69777b85d167df28f469e77f0fcbb8f9.zip
op-kernel-dev-540207ae69777b85d167df28f469e77f0fcbb8f9.tar.gz
fou: avoid missing unlock in failure path
Fixes: 7a6c8c34e5b7 ("fou: implement FOU_CMD_GET") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/fou.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
index af150b4..34968cd 100644
--- a/net/ipv4/fou.c
+++ b/net/ipv4/fou.c
@@ -711,11 +711,10 @@ static int fou_nl_dump(struct sk_buff *skb, struct netlink_callback *cb)
cb->nlh->nlmsg_seq, NLM_F_MULTI,
skb, FOU_CMD_GET);
if (ret)
- goto done;
+ break;
}
mutex_unlock(&fn->fou_lock);
-done:
cb->args[0] = idx;
return skb->len;
}
OpenPOWER on IntegriCloud