summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2011-09-19 17:04:37 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2011-09-19 17:04:37 -0700
commit1a51410abe7d0ee4b1d112780f46df87d3621043 (patch)
treefc8a3d70b9fca3692e33e528a420eae1e5407850
parentb6a68a5ba4a5111379625d6d921e1c24fc17dc3a (diff)
downloadop-kernel-dev-1a51410abe7d0ee4b1d112780f46df87d3621043.zip
op-kernel-dev-1a51410abe7d0ee4b1d112780f46df87d3621043.tar.gz
Make TASKSTATS require root access
Ok, this isn't optimal, since it means that 'iotop' needs admin capabilities, and we may have to work on this some more. But at the same time it is very much not acceptable to let anybody just read anybody elses IO statistics quite at this level. Use of the GENL_ADMIN_PERM suggested by Johannes Berg as an alternative to checking the capabilities by hand. Reported-by: Vasiliy Kulikov <segoon@openwall.com> Cc: Johannes Berg <johannes.berg@intel.com> Acked-by: Balbir Singh <bsingharora@gmail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--kernel/taskstats.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/taskstats.c b/kernel/taskstats.c
index e19ce14..e660464 100644
--- a/kernel/taskstats.c
+++ b/kernel/taskstats.c
@@ -655,6 +655,7 @@ static struct genl_ops taskstats_ops = {
.cmd = TASKSTATS_CMD_GET,
.doit = taskstats_user_cmd,
.policy = taskstats_cmd_get_policy,
+ .flags = GENL_ADMIN_PERM,
};
static struct genl_ops cgroupstats_ops = {
OpenPOWER on IntegriCloud