diff options
| author | Andre Noll <maan@systemlinux.org> | 2008-07-11 22:02:21 +1000 |
|---|---|---|
| committer | Neil Brown <neilb@suse.de> | 2008-07-11 22:02:21 +1000 |
| commit | 26ef379f53993b1da3c19b63257cd47e1d9cd672 (patch) | |
| tree | c02f2acfb14c6b8294e101f53fb10a9d978844bb | |
| parent | 80fab1d77b2852711917baa437e4fdab31c21fef (diff) | |
| download | op-kernel-dev-26ef379f53993b1da3c19b63257cd47e1d9cd672.zip op-kernel-dev-26ef379f53993b1da3c19b63257cd47e1d9cd672.tar.gz | |
md: get_disk_info(): Don't convert between signed and unsigned and back.
The current code copies a signed int from user space, converts it to
unsigned and passes the unsigned value to find_rdev_nr() which expects
a signed value. Simply pass the signed value from user space directly.
Signed-off-by: Andre Noll <maan@systemlinux.org>
Signed-off-by: Neil Brown <neilb@suse.de>
| -rw-r--r-- | drivers/md/md.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index bd1dc72..328e247 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -4186,15 +4186,12 @@ out: static int get_disk_info(mddev_t * mddev, void __user * arg) { mdu_disk_info_t info; - unsigned int nr; mdk_rdev_t *rdev; if (copy_from_user(&info, arg, sizeof(info))) return -EFAULT; - nr = info.number; - - rdev = find_rdev_nr(mddev, nr); + rdev = find_rdev_nr(mddev, info.number); if (rdev) { info.major = MAJOR(rdev->bdev->bd_dev); info.minor = MINOR(rdev->bdev->bd_dev); |
