diff options
| author | Alexander Gordeev <lasaine@lvk.cs.msu.su> | 2011-01-12 17:00:54 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-01-13 08:03:20 -0800 |
| commit | 29f347c9faf53cfb953e4d529e6e632482214e62 (patch) | |
| tree | 2b55952b446dcc74fbd70820c7499e78a26cd973 | |
| parent | 2a5cd6e2fb1984cc83f08b3645bf394830ac7825 (diff) | |
| download | op-kernel-dev-29f347c9faf53cfb953e4d529e6e632482214e62.zip op-kernel-dev-29f347c9faf53cfb953e4d529e6e632482214e62.tar.gz | |
pps: use BUG_ON for kernel API safety checks
This way less overhead is involved when running production kernel. If you
want to debug a pps client module please define DEBUG to enable the
checks.
Signed-off-by: Alexander Gordeev <lasaine@lvk.cs.msu.su>
Acked-by: Rodolfo Giometti <giometti@linux.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/pps/kapi.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c index c42d3cb..3e8eb3f 100644 --- a/drivers/pps/kapi.c +++ b/drivers/pps/kapi.c @@ -166,10 +166,8 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event, int captured = 0; struct pps_ktime ts_real; - if ((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0) { - dev_err(pps->dev, "unknown event (%x)\n", event); - return; - } + /* check event type */ + BUG_ON((event & (PPS_CAPTUREASSERT | PPS_CAPTURECLEAR)) == 0); dev_dbg(pps->dev, "PPS event at %ld.%09ld\n", ts->ts_real.tv_sec, ts->ts_real.tv_nsec); |
