summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-05-28 22:58:46 +0200
committerSamuel Ortiz <sameo@linux.intel.com>2010-08-12 11:27:19 +0200
commit25fe24f884015ba2e1e39376deb055bbbdc5ba83 (patch)
tree75aa1f9cdefabc453908f150a66cf8be7ff4df14
parentc0d4010e11e23d6f55f9bdda63b1974f35af71bf (diff)
downloadop-kernel-dev-25fe24f884015ba2e1e39376deb055bbbdc5ba83.zip
op-kernel-dev-25fe24f884015ba2e1e39376deb055bbbdc5ba83.tar.gz
mfd: kzalloc doesn't return ERR_PTR
Use !x rather than IS_ERR(x) to test the result of kzalloc. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression x,E; @@ x = \(kmalloc\|kzalloc\|kcalloc\)(...) ... when != x = E - IS_ERR(x) + !x // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
-rw-r--r--drivers/mfd/abx500-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c
index 3b3b97e..f12720d 100644
--- a/drivers/mfd/abx500-core.c
+++ b/drivers/mfd/abx500-core.c
@@ -36,7 +36,7 @@ int abx500_register_ops(struct device *dev, struct abx500_ops *ops)
struct abx500_device_entry *dev_entry;
dev_entry = kzalloc(sizeof(struct abx500_device_entry), GFP_KERNEL);
- if (IS_ERR(dev_entry)) {
+ if (!dev_entry) {
dev_err(dev, "register_ops kzalloc failed");
return -ENOMEM;
}
OpenPOWER on IntegriCloud