summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2008-03-04 15:00:13 -0800
committerLen Brown <len.brown@intel.com>2008-03-18 02:31:34 -0400
commitabc5a87f4e627e058813a95b112e9f5f21668f9d (patch)
treee0ecdbe2a99e7071fd0d47fdaab36d27e8a7321d
parent93d74463d018ddf05c169ad399e62e90e0f82fc0 (diff)
downloadop-kernel-dev-abc5a87f4e627e058813a95b112e9f5f21668f9d.zip
op-kernel-dev-abc5a87f4e627e058813a95b112e9f5f21668f9d.tar.gz
asus_acpi: remove misleading mask
led_out is boolean, so there is no functional change here, but apparently an extra mask with 1 caused some style checkers to flag this as logic bug. Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Luca Tettamanti <kronos.it@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r--drivers/acpi/asus_acpi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
index d25ef96..44ad90c 100644
--- a/drivers/acpi/asus_acpi.c
+++ b/drivers/acpi/asus_acpi.c
@@ -610,7 +610,7 @@ write_led(const char __user * buffer, unsigned long count,
(led_out) ? (hotk->status | ledmask) : (hotk->status & ~ledmask);
if (invert) /* invert target value */
- led_out = !led_out & 0x1;
+ led_out = !led_out;
if (!write_acpi_int(hotk->handle, ledname, led_out, NULL))
printk(KERN_WARNING "Asus ACPI: LED (%s) write failed\n",
OpenPOWER on IntegriCloud