diff options
| author | Lukas Czerner <lczerner@redhat.com> | 2013-05-27 23:32:35 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2013-05-27 23:32:35 -0400 |
| commit | 78fb9cdf035d88a39a5e5f83bb8788e4fe7c1f72 (patch) | |
| tree | 7f5feecf913163a790d468908c9696e2181f5a36 | |
| parent | c121ffd013e5ab7c04414a5f0cb3604731775174 (diff) | |
| download | op-kernel-dev-78fb9cdf035d88a39a5e5f83bb8788e4fe7c1f72.zip op-kernel-dev-78fb9cdf035d88a39a5e5f83bb8788e4fe7c1f72.tar.gz | |
ext4: remove unused code from ext4_remove_blocks()
The "head removal" branch in the condition is never used in any code
path in ext4 since the function only caller ext4_ext_rm_leaf() will make
sure that the extent is properly split before removing blocks. Note that
there is a bug in this branch anyway.
This commit removes the unused code completely and makes use of
ext4_error() instead of printk if dubious range is provided.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/extents.c | 21 |
1 files changed, 4 insertions, 17 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index bc0f1910..18c3f1a 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -2432,23 +2432,10 @@ static int ext4_remove_blocks(handle_t *handle, struct inode *inode, *partial_cluster = EXT4_B2C(sbi, pblk); else *partial_cluster = 0; - } else if (from == le32_to_cpu(ex->ee_block) - && to <= le32_to_cpu(ex->ee_block) + ee_len - 1) { - /* head removal */ - ext4_lblk_t num; - ext4_fsblk_t start; - - num = to - from; - start = ext4_ext_pblock(ex); - - ext_debug("free first %u blocks starting %llu\n", num, start); - ext4_free_blocks(handle, inode, NULL, start, num, flags); - - } else { - printk(KERN_INFO "strange request: removal(2) " - "%u-%u from %u:%u\n", - from, to, le32_to_cpu(ex->ee_block), ee_len); - } + } else + ext4_error(sbi->s_sb, "strange request: removal(2) " + "%u-%u from %u:%u\n", + from, to, le32_to_cpu(ex->ee_block), ee_len); return 0; } |
