diff options
author | Jens Axboe <jaxboe@fusionio.com> | 2010-11-16 10:10:12 +0100 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2010-11-16 10:10:12 +0100 |
commit | 5fbf85639287b6ea287f4f5e5e7e36608f0f60bd (patch) | |
tree | 608a51e6ee572dba94b43f1933e49ab88562e4c0 | |
parent | a02056349cdea2252cd2b21643ebf025e83a29f2 (diff) | |
parent | bdc85df7a8417b9893443ff5520804699416b6f3 (diff) | |
download | op-kernel-dev-5fbf85639287b6ea287f4f5e5e7e36608f0f60bd.zip op-kernel-dev-5fbf85639287b6ea287f4f5e5e7e36608f0f60bd.tar.gz |
Merge branch 'for-2.6.38/rc2-holder' into for-2.6.38/core
-rw-r--r-- | Documentation/cgroups/blkio-controller.txt | 27 | ||||
-rw-r--r-- | block/blk-cgroup.c | 4 |
2 files changed, 27 insertions, 4 deletions
diff --git a/Documentation/cgroups/blkio-controller.txt b/Documentation/cgroups/blkio-controller.txt index d6da611..4ed7b5c 100644 --- a/Documentation/cgroups/blkio-controller.txt +++ b/Documentation/cgroups/blkio-controller.txt @@ -89,6 +89,33 @@ Throttling/Upper Limit policy Limits for writes can be put using blkio.write_bps_device file. +Hierarchical Cgroups +==================== +- Currently none of the IO control policy supports hierarhical groups. But + cgroup interface does allow creation of hierarhical cgroups and internally + IO policies treat them as flat hierarchy. + + So this patch will allow creation of cgroup hierarhcy but at the backend + everything will be treated as flat. So if somebody created a hierarchy like + as follows. + + root + / \ + test1 test2 + | + test3 + + CFQ and throttling will practically treat all groups at same level. + + pivot + / | \ \ + root test1 test2 test3 + + Down the line we can implement hierarchical accounting/control support + and also introduce a new cgroup file "use_hierarchy" which will control + whether cgroup hierarchy is viewed as flat or hierarchical by the policy.. + This is how memory controller also has implemented the things. + Various user visible config options =================================== CONFIG_BLK_CGROUP diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index b1febd0..455768a 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1452,10 +1452,6 @@ blkiocg_create(struct cgroup_subsys *subsys, struct cgroup *cgroup) goto done; } - /* Currently we do not support hierarchy deeper than two level (0,1) */ - if (parent != cgroup->top_cgroup) - return ERR_PTR(-EPERM); - blkcg = kzalloc(sizeof(*blkcg), GFP_KERNEL); if (!blkcg) return ERR_PTR(-ENOMEM); |