summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDolev Raviv <draviv@codeaurora.org>2014-10-23 13:25:14 +0300
committerChristoph Hellwig <hch@lst.de>2014-11-20 17:47:41 +0100
commit233b594bdf6d846f03816eec1c19ccbd7e4618c0 (patch)
treeb81879930e1a5b11820b15c08847ef1fb67ef1c2
parent5064636c759628caee3b855048be25a9a33cc8ad (diff)
downloadop-kernel-dev-233b594bdf6d846f03816eec1c19ccbd7e4618c0.zip
op-kernel-dev-233b594bdf6d846f03816eec1c19ccbd7e4618c0.tar.gz
scsi: ufs: fix static checker errors in ufshcd_system_suspend
This patch fixes newly introduced sparse warning in ufshcd_system_suspend, introduced by UFS power management series. Sparse warning: drivers/scsi/ufs/ufshcd.c:5118 ufshcd_system_suspend() error: we previously assumed 'hba' could be null (see line 5089) To fix it, we return 0 in case HBA is not initialized or is not powered. Signed-off-by: Dolev Raviv <draviv@codeaurora.org> Reviewed-by: Maya Erez <merez@codeaurora.org> Signed-off-by: Christoph Hellwig <hch@lst.de>
-rw-r--r--drivers/scsi/ufs/ufshcd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 77a4e38..d3f6ddb 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5104,7 +5104,7 @@ int ufshcd_system_suspend(struct ufs_hba *hba)
int ret = 0;
if (!hba || !hba->is_powered)
- goto out;
+ return 0;
if (pm_runtime_suspended(hba->dev)) {
if (hba->rpm_lvl == hba->spm_lvl)
OpenPOWER on IntegriCloud