diff options
| author | Eric Biggers <ebiggers@google.com> | 2017-12-08 15:13:27 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2017-12-08 15:13:27 +0000 |
| commit | a2d8737d5c781d388b553dd085b56d7295fffc6c (patch) | |
| tree | e1a015e62fcb62ea4b6c1a3993e0dcbf415cffc5 | |
| parent | fd6d2e506ce6f850d45342a15c896591291b77b5 (diff) | |
| download | op-kernel-dev-a2d8737d5c781d388b553dd085b56d7295fffc6c.zip op-kernel-dev-a2d8737d5c781d388b553dd085b56d7295fffc6c.tar.gz | |
KEYS: remove unnecessary get/put of explicit dest_keyring
In request_key_and_link(), in the case where the dest_keyring was
explicitly specified, there is no need to get another reference to
dest_keyring before calling key_link(), then drop it afterwards. This
is because by definition, we already have a reference to dest_keyring.
This change is useful because we'll be making
construct_get_dest_keyring() able to return an error code, and we don't
want to have to handle that error here for no reason.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
| -rw-r--r-- | security/keys/request_key.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/security/keys/request_key.c b/security/keys/request_key.c index e8036cd..c6880af 100644 --- a/security/keys/request_key.c +++ b/security/keys/request_key.c @@ -546,9 +546,7 @@ struct key *request_key_and_link(struct key_type *type, if (!IS_ERR(key_ref)) { key = key_ref_to_ptr(key_ref); if (dest_keyring) { - construct_get_dest_keyring(&dest_keyring); ret = key_link(dest_keyring, key); - key_put(dest_keyring); if (ret < 0) { key_put(key); key = ERR_PTR(ret); |
