diff options
author | Andy Whitcroft <apw@shadowen.org> | 2008-10-15 22:02:23 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-16 11:21:35 -0700 |
commit | f055663c5853aa1d9f4c86351a4637462a0b9041 (patch) | |
tree | ff000717ccecc62cea6832852f2e3e229007489b | |
parent | 2a1bc5d5c5096f2dfb6f8b18f39ecb718f101535 (diff) | |
download | op-kernel-dev-f055663c5853aa1d9f4c86351a4637462a0b9041.zip op-kernel-dev-f055663c5853aa1d9f4c86351a4637462a0b9041.tar.gz |
checkpatch: report the correct lines for single statement blocks
Report the correct lines for single statement blocks. Currently we are
reporting the right number of lines, but not skipping the negative lines.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rwxr-xr-x | scripts/checkpatch.pl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c7980ff..36825c3 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2214,10 +2214,10 @@ sub process { } if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) { my $herectx = $here . "\n";; - my $end = $linenr + statement_rawlines($block) - 1; + my $cnt = statement_rawlines($block); - for (my $ln = $linenr - 1; $ln < $end; $ln++) { - $herectx .= $rawlines[$ln] . "\n";; + for (my $n = 0; $n < $cnt; $n++) { + $herectx .= raw_line($linenr, $n) . "\n";; } WARN("braces {} are not necessary for single statement blocks\n" . $herectx); |