diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 11:38:50 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-12-26 22:28:23 +0100 |
| commit | 8a240c311715c2e34f9a8d6e69d6f85a9f484c6d (patch) | |
| tree | d8ec2df469dbef1f8c4bff4c0216dbd743c3e784 | |
| parent | 6a681b61470e1daf4fd51581c21147f92fe7b75d (diff) | |
| download | op-kernel-dev-8a240c311715c2e34f9a8d6e69d6f85a9f484c6d.zip op-kernel-dev-8a240c311715c2e34f9a8d6e69d6f85a9f484c6d.tar.gz | |
gpio: sta2x11: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Alessandro Rubini <rubini@gnudd.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/gpio/gpio-sta2x11.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-sta2x11.c b/drivers/gpio/gpio-sta2x11.c index 55e47828..af0be81 100644 --- a/drivers/gpio/gpio-sta2x11.c +++ b/drivers/gpio/gpio-sta2x11.c @@ -90,7 +90,7 @@ static int gsta_gpio_get(struct gpio_chip *gpio, unsigned nr) struct gsta_regs __iomem *regs = __regs(chip, nr); u32 bit = __bit(nr); - return readl(®s->dat) & bit; + return !!(readl(®s->dat) & bit); } static int gsta_gpio_direction_output(struct gpio_chip *gpio, unsigned nr, |
