summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTobias Klauser <tklauser@distanz.ch>2016-10-18 08:44:17 +0200
committerDavid S. Miller <davem@davemloft.net>2016-10-18 10:25:34 -0400
commit403f0727cb35d3ce82166340d792e20c7d5adb30 (patch)
treeb1fa897c38544ec68fbdcb0efeb807a7929124c2
parent3f3177bb680fc08300e6f2341f44755ff90a358a (diff)
downloadop-kernel-dev-403f0727cb35d3ce82166340d792e20c7d5adb30.zip
op-kernel-dev-403f0727cb35d3ce82166340d792e20c7d5adb30.tar.gz
vlan: Remove unnecessary comparison of unsigned against 0
args.u.name_type is of type unsigned int and is always >= 0. This fixes the following GCC warning: net/8021q/vlan.c: In function ‘vlan_ioctl_handler’: net/8021q/vlan.c:574:14: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/8021q/vlan.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 8de138d..f8903c1 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -571,8 +571,7 @@ static int vlan_ioctl_handler(struct net *net, void __user *arg)
err = -EPERM;
if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
break;
- if ((args.u.name_type >= 0) &&
- (args.u.name_type < VLAN_NAME_TYPE_HIGHEST)) {
+ if (args.u.name_type < VLAN_NAME_TYPE_HIGHEST) {
struct vlan_net *vn;
vn = net_generic(net, vlan_net_id);
OpenPOWER on IntegriCloud