diff options
| author | Dmitry Torokhov <dtor@chromium.org> | 2014-11-14 14:12:21 -0800 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2014-11-17 15:04:04 -0500 |
| commit | 4c69f05eaa428e37890daf88b86a567ce615570b (patch) | |
| tree | f7f5b1df8b1d4e2ef731e56ecffa9f8e7b617738 | |
| parent | 8180bd47b043507568056f74f69b6a5abea26514 (diff) | |
| download | op-kernel-dev-4c69f05eaa428e37890daf88b86a567ce615570b.zip op-kernel-dev-4c69f05eaa428e37890daf88b86a567ce615570b.tar.gz | |
brcmfmac: fix error handling of irq_of_parse_and_map
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Cc: stable@vger.kernel.org # v3.17
Acked-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| -rw-r--r-- | drivers/net/wireless/brcm80211/brcmfmac/of.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/of.c b/drivers/net/wireless/brcm80211/brcmfmac/of.c index f05f527..927bffd 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/of.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/of.c @@ -40,8 +40,8 @@ void brcmf_of_probe(struct brcmf_sdio_dev *sdiodev) return; irq = irq_of_parse_and_map(np, 0); - if (irq < 0) { - brcmf_err("interrupt could not be mapped: err=%d\n", irq); + if (!irq) { + brcmf_err("interrupt could not be mapped\n"); devm_kfree(dev, sdiodev->pdata); return; } |
