summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <error27@gmail.com>2011-08-24 01:29:22 +0000
committerDavid S. Miller <davem@davemloft.net>2011-08-26 12:55:18 -0400
commit44861f4455a77beaec2e53459c77b7fb0eda91a7 (patch)
tree601361470575247574b7b22f95d75e44804206df
parent3756a89f3d039d8a6aa2556f8d57d4b2ec25d5dd (diff)
downloadop-kernel-dev-44861f4455a77beaec2e53459c77b7fb0eda91a7.zip
op-kernel-dev-44861f4455a77beaec2e53459c77b7fb0eda91a7.tar.gz
bna: unlock on error path in pnad_pci_probe()
We introduced a new lock here, so there was error path which needs an unlock now. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Rasesh Mody <rmody@brocade.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/brocade/bna/bnad.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
index bdfda07..6ad4b47 100644
--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c
@@ -3167,7 +3167,7 @@ bnad_pci_probe(struct pci_dev *pdev,
*/
err = bnad_pci_init(bnad, pdev, &using_dac);
if (err)
- goto free_netdev;
+ goto unlock_mutex;
/*
* Initialize bnad structure
@@ -3296,9 +3296,9 @@ drv_uninit:
bnad_uninit(bnad);
pci_uninit:
bnad_pci_uninit(pdev);
+unlock_mutex:
mutex_unlock(&bnad->conf_mutex);
bnad_lock_uninit(bnad);
-free_netdev:
free_netdev(netdev);
return err;
}
OpenPOWER on IntegriCloud