diff options
| author | Eric Dumazet <dada1@cosmosbay.com> | 2008-04-25 00:29:00 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-04-25 00:29:34 -0700 |
| commit | 461e6c856faf9cdd8862fa4d0785974a64e39dba (patch) | |
| tree | c28394f1c814b98d993e646dd80717bc9c001d2c | |
| parent | 5b3f129c5592ca35b3fe8916767c58b98710478c (diff) | |
| download | op-kernel-dev-461e6c856faf9cdd8862fa4d0785974a64e39dba.zip op-kernel-dev-461e6c856faf9cdd8862fa4d0785974a64e39dba.tar.gz | |
xfrm: alg_key_len & alg_icv_len should be unsigned
In commit ba749ae98d5aa9d2ce9a7facde0deed454f92230 ([XFRM]: alg_key_len
should be unsigned to avoid integer divides
<http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=ba749ae98d5aa9d2ce9a7facde0deed454f92230>)
alg_key_len field of struct xfrm_algo was converted to unsigned int to
avoid integer divides.
Then Herbert in commit 1a6509d991225ad210de54c63314fd9542922095
([IPSEC]: Add support for combined mode algorithms) added a new
structure xfrm_algo_aead, that resurrected a signed int for alg_key_len
and re-introduce integer divides.
This patch avoids these divides and saves 64 bytes of text on i386.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | include/linux/xfrm.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h index 0c82c80..2ca6bae 100644 --- a/include/linux/xfrm.h +++ b/include/linux/xfrm.h @@ -97,10 +97,10 @@ struct xfrm_algo { }; struct xfrm_algo_aead { - char alg_name[64]; - int alg_key_len; /* in bits */ - int alg_icv_len; /* in bits */ - char alg_key[0]; + char alg_name[64]; + unsigned int alg_key_len; /* in bits */ + unsigned int alg_icv_len; /* in bits */ + char alg_key[0]; }; struct xfrm_stats { |
