diff options
| author | Roel Kluin <12o3l@tiscali.nl> | 2008-04-23 23:59:36 +0200 |
|---|---|---|
| committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2008-04-28 21:24:45 +0100 |
| commit | 681587c58639444215a7c88f7471819997d2f226 (patch) | |
| tree | dc56d626f84e58df57526c26957b72dd1da12498 | |
| parent | 62783679540fbdfd74e10fbe9478d978141ba45f (diff) | |
| download | op-kernel-dev-681587c58639444215a7c88f7471819997d2f226.zip op-kernel-dev-681587c58639444215a7c88f7471819997d2f226.tar.gz | |
[ARM] serial: s3c2410: platform_get_irq() may return signed unnoticed
port->irq is unsigned, platform_get_irq() may return signed unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
| -rw-r--r-- | drivers/serial/s3c2410.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/serial/s3c2410.c b/drivers/serial/s3c2410.c index 4ffa258..da5a02c 100644 --- a/drivers/serial/s3c2410.c +++ b/drivers/serial/s3c2410.c @@ -1022,6 +1022,7 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, struct uart_port *port = &ourport->port; struct s3c2410_uartcfg *cfg; struct resource *res; + int ret; dbg("s3c24xx_serial_init_port: port=%p, platdev=%p\n", port, platdev); @@ -1064,9 +1065,11 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, port->mapbase = res->start; port->membase = S3C24XX_VA_UART + (res->start - S3C24XX_PA_UART); - port->irq = platform_get_irq(platdev, 0); - if (port->irq < 0) + ret = platform_get_irq(platdev, 0); + if (ret < 0) port->irq = 0; + else + port->irq = ret; ourport->clk = clk_get(&platdev->dev, "uart"); |
