summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmos Kong <akong@redhat.com>2014-09-11 22:20:39 +0930
committerRusty Russell <rusty@rustcorp.com.au>2014-09-11 22:28:34 +0930
commit3856e548372513665670ca5db60d9a74b970fe0d (patch)
tree50bf263fb7a3269e38a58c9177741f356912342b
parent7ec62d421bdf29cb31101ae2689f7f3a9906289a (diff)
downloadop-kernel-dev-3856e548372513665670ca5db60d9a74b970fe0d.zip
op-kernel-dev-3856e548372513665670ca5db60d9a74b970fe0d.tar.gz
virtio-rng: fix stuck of hot-unplugging busy device
When we try to hot-remove a busy virtio-rng device from QEMU monitor, the device can't be hot-removed. Because virtio-rng driver hangs at wait_for_completion_killable(). This patch exits the waiting by completing have_data completion before unregistering, resets data_avail to avoid the hwrng core use wrong buffer bytes. Signed-off-by: Amos Kong <akong@redhat.com> Reviewed-by: Amit Shah <amit.shah@redhat.com> Cc: stable@vger.kernel.org Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-rw-r--r--drivers/char/hw_random/virtio-rng.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c
index 2e3139e..849b228 100644
--- a/drivers/char/hw_random/virtio-rng.c
+++ b/drivers/char/hw_random/virtio-rng.c
@@ -137,6 +137,8 @@ static void remove_common(struct virtio_device *vdev)
{
struct virtrng_info *vi = vdev->priv;
+ vi->data_avail = 0;
+ complete(&vi->have_data);
vdev->config->reset(vdev);
vi->busy = false;
if (vi->hwrng_register_done)
OpenPOWER on IntegriCloud