summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Johansen <john.johansen@canonical.com>2017-11-15 15:25:30 -0800
committerJohn Johansen <john.johansen@canonical.com>2017-11-21 02:17:13 -0800
commit4633307e5ed6128975595df43f796a10c41d11c1 (patch)
tree69a59e0adcd575811ee7b05190111929d89ca173
parente3bcfc148588e409685479f3d20ba3d66ae30035 (diff)
downloadop-kernel-dev-4633307e5ed6128975595df43f796a10c41d11c1.zip
op-kernel-dev-4633307e5ed6128975595df43f796a10c41d11c1.tar.gz
apparmor: fix leak of null profile name if profile allocation fails
Fixes: d07881d2edb0 ("apparmor: move new_null_profile to after profile lookup fns()") Reported-by: Seth Arnold <seth.arnold@canonical.com> Signed-off-by: John Johansen <john.johansen@canonical.com>
-rw-r--r--security/apparmor/policy.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c
index 4243b0c..586b249 100644
--- a/security/apparmor/policy.c
+++ b/security/apparmor/policy.c
@@ -502,7 +502,7 @@ struct aa_profile *aa_new_null_profile(struct aa_profile *parent, bool hat,
{
struct aa_profile *p, *profile;
const char *bname;
- char *name;
+ char *name = NULL;
AA_BUG(!parent);
@@ -562,6 +562,7 @@ out:
return profile;
fail:
+ kfree(name);
aa_free_profile(profile);
return NULL;
}
OpenPOWER on IntegriCloud