diff options
| author | Felipe Balbi <balbi@ti.com> | 2013-02-20 10:31:42 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-15 09:39:15 -0700 |
| commit | 8f46baaa7ec6cd0851794020b31958e64679dd26 (patch) | |
| tree | d075f91c3a8ef47237df697664efb22b7e676a14 | |
| parent | be871b7e54711479d3b9d3617d49898770830db2 (diff) | |
| download | op-kernel-dev-8f46baaa7ec6cd0851794020b31958e64679dd26.zip op-kernel-dev-8f46baaa7ec6cd0851794020b31958e64679dd26.tar.gz | |
base: core: WARN() about bogus permissions on device attributes
Whenever a struct device_attribute is registered
with mismatched permissions - read permission without
a show routine or write permission without store
routine - we will issue a big warning so we catch
those early enough.
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/base/core.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/base/core.c b/drivers/base/core.c index 56536f4b0..a7391a3 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -563,8 +563,15 @@ int device_create_file(struct device *dev, const struct device_attribute *attr) { int error = 0; - if (dev) + + if (dev) { + WARN(((attr->attr.mode & S_IWUGO) && !attr->store), + "Write permission without 'store'\n"); + WARN(((attr->attr.mode & S_IRUGO) && !attr->show), + "Read permission without 'show'\n"); error = sysfs_create_file(&dev->kobj, &attr->attr); + } + return error; } |
