summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@lip6.fr>2014-01-13 17:17:24 +0100
committerDavid S. Miller <davem@davemloft.net>2014-01-15 13:43:03 -0800
commit9895c503ef5b32c1ff4c4c224d6e8db2935dc3c0 (patch)
treebe657e2227765e7d7b03863520da581b5b83e59c
parente3e4e01cb7c8b56b634fca53fcb05563c23fb656 (diff)
downloadop-kernel-dev-9895c503ef5b32c1ff4c4c224d6e8db2935dc3c0.zip
op-kernel-dev-9895c503ef5b32c1ff4c4c224d6e8db2935dc3c0.tar.gz
ksz884x: delete useless variable
Delete a variable that is at most only assigned to a constant, but never used otherwise. In this code, it is the variable result that is used for the return code, not rc. A simplified version of the semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ type T; identifier i; constant c; @@ -T i; <... when != i -i = c; ...> // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/micrel/ksz884x.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 8e9dad7..ce84dc2 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -5853,15 +5853,12 @@ static int netdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
struct dev_info *hw_priv = priv->adapter;
struct ksz_hw *hw = &hw_priv->hw;
struct ksz_port *port = &priv->port;
- int rc;
int result = 0;
struct mii_ioctl_data *data = if_mii(ifr);
if (down_interruptible(&priv->proc_sem))
return -ERESTARTSYS;
- /* assume success */
- rc = 0;
switch (cmd) {
/* Get address of MII PHY in use. */
case SIOCGMIIPHY:
OpenPOWER on IntegriCloud