diff options
| author | Geliang Tang <geliangtang@gmail.com> | 2017-05-13 11:16:00 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-05-17 12:20:54 +0200 |
| commit | ca2ef0d5cd0568d4ef60da6ff6bd7f69f317407a (patch) | |
| tree | 5eeb4a9314c62cd63d24462431c333075f5e96a7 | |
| parent | 2aa3add0cc8f4b937062f33332297486c95ae966 (diff) | |
| download | op-kernel-dev-ca2ef0d5cd0568d4ef60da6ff6bd7f69f317407a.zip op-kernel-dev-ca2ef0d5cd0568d4ef60da6ff6bd7f69f317407a.tar.gz | |
USB: iowarrior: use memdup_user
Use memdup_user() helper instead of open-coding to simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/misc/iowarrior.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 7756953..816afad 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -368,14 +368,9 @@ static ssize_t iowarrior_write(struct file *file, case USB_DEVICE_ID_CODEMERCS_IOWPV2: case USB_DEVICE_ID_CODEMERCS_IOW40: /* IOW24 and IOW40 use a synchronous call */ - buf = kmalloc(count, GFP_KERNEL); - if (!buf) { - retval = -ENOMEM; - goto exit; - } - if (copy_from_user(buf, user_buffer, count)) { - retval = -EFAULT; - kfree(buf); + buf = memdup_user(user_buffer, count); + if (IS_ERR(buf)) { + retval = PTR_ERR(buf); goto exit; } retval = usb_set_report(dev->interface, 2, 0, buf, count); |
