summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2015-07-04 13:23:42 -0700
committerGuenter Roeck <linux@roeck-us.net>2015-07-29 20:06:50 -0700
commit9200bc4c28cd8992eb5379345abd6b4f0c93df16 (patch)
treea775ada60b166e99a1860cfb2cde1bd37ca15c26
parent0d6aaffc3a6db642e0a165ba4d17d6d7bbaf5201 (diff)
downloadop-kernel-dev-9200bc4c28cd8992eb5379345abd6b4f0c93df16.zip
op-kernel-dev-9200bc4c28cd8992eb5379345abd6b4f0c93df16.tar.gz
hwmon: (nct7802) Fix integer overflow seen when writing voltage limits
Writing a large value into a voltage limit attribute can result in an overflow due to an auto-conversion from unsigned long to unsigned int. Cc: Constantine Shulyupin <const@MakeLinux.com> Reviewed-by: Jean Delvare <jdelvare@suse.de> Cc: stable@vger.kernel.org # v4.1+ Signed-off-by: Guenter Roeck <linux@roeck-us.net>
-rw-r--r--drivers/hwmon/nct7802.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
index 28fcb2e..fbfc02b 100644
--- a/drivers/hwmon/nct7802.c
+++ b/drivers/hwmon/nct7802.c
@@ -195,7 +195,7 @@ abort:
}
static int nct7802_write_voltage(struct nct7802_data *data, int nr, int index,
- unsigned int voltage)
+ unsigned long voltage)
{
int shift = 8 - REG_VOLTAGE_LIMIT_MSB_SHIFT[index - 1][nr];
int err;
OpenPOWER on IntegriCloud