diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-11-30 22:22:54 +0300 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2016-11-30 23:16:31 +0100 |
| commit | 501634759d55a5b56967de6d9465acf02bbc3565 (patch) | |
| tree | c0bfc2611d8d8658a115592ba9ba1df26c294b47 | |
| parent | e5517c2a5a49ed5e99047008629f1cd60246ea0e (diff) | |
| download | op-kernel-dev-501634759d55a5b56967de6d9465acf02bbc3565.zip op-kernel-dev-501634759d55a5b56967de6d9465acf02bbc3565.tar.gz | |
ACPI / CPPC: set an error code on probe error path
We should return -EINVAL (instead of 0) if get_cpu_device() fails.
Fixes: 158c998ea44b (ACPI / CPPC: add sysfs support to compute delivered performance)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/acpi/cppc_acpi.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index d0d0504..e0ea8f5 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -784,8 +784,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) /* Add per logical CPU nodes for reading its feedback counters. */ cpu_dev = get_cpu_device(pr->id); - if (!cpu_dev) + if (!cpu_dev) { + ret = -EINVAL; goto out_free; + } ret = kobject_init_and_add(&cpc_ptr->kobj, &cppc_ktype, &cpu_dev->kobj, "acpi_cppc"); |
