diff options
| author | Jan Kara <jack@suse.cz> | 2014-10-22 09:06:49 +0200 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2014-10-22 09:08:03 +0200 |
| commit | 474d2605d119479e5aa050f738632e63589d4bb5 (patch) | |
| tree | aa16eb470b59d74bbc112eb02876c82abffdce34 | |
| parent | 7938db449bbc55bbeb164bec7af406212e7e98f1 (diff) | |
| download | op-kernel-dev-474d2605d119479e5aa050f738632e63589d4bb5.zip op-kernel-dev-474d2605d119479e5aa050f738632e63589d4bb5.tar.gz | |
quota: Properly return errors from dquot_writeback_dquots()
Due to a switched left and right side of an assignment,
dquot_writeback_dquots() never returned error. This could result in
errors during quota writeback to not be reported to userspace properly.
Fix it.
CC: stable@vger.kernel.org
Coverity-id: 1226884
Signed-off-by: Jan Kara <jack@suse.cz>
| -rw-r--r-- | fs/quota/dquot.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 8b663b2..6b45272 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -634,7 +634,7 @@ int dquot_writeback_dquots(struct super_block *sb, int type) dqstats_inc(DQST_LOOKUPS); err = sb->dq_op->write_dquot(dquot); if (!ret && err) - err = ret; + ret = err; dqput(dquot); spin_lock(&dq_list_lock); } |
